Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements for modern Nim #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PMunch
Copy link

@PMunch PMunch commented May 26, 2023

  • Changed every occurrence of Nimrod to Nim
  • Cleaned up some uses of result, return result, and automatic initialisation
  • Improved getMOverNBits to not catch IndexError as that would fail with --panics:on
  • Cleaned up some signatures with default values e.g. arg: int = 10 to simply arg = 10
  • Cleaned up some calls where arguments where named like call(item = item)
  • Removed some comments like "Can be called with method style syntax like " as this is just a language feature
  • Combined some let statements into blocks
  • Added more tests based on the extra code in the main module
  • Switched to camelCase from snake_case (this is a Nim style guide choice, if you would like to keep it snake_case I can change it back)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant