Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scc version 3.2.0 fails to compile with 32 bit golang toolchain in Windows #416

Closed
Biswa96 opened this issue Nov 29, 2023 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@Biswa96
Copy link

Biswa96 commented Nov 29, 2023

Describe the bug

scc version 3.2.0 fails to compile with 32 bit golang toolchain in Windows.

To Reproduce

Compile the scc version 3.2.0 using the commands from here https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-scc/PKGBUILD

It fails with the following error.

cmd\badges\simplecache.go:90:21: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in assignment (overflows)

Expected behavior

The build should not fail.

Desktop (please complete the following information):

  • OS: Windows 10
@boyter
Copy link
Owner

boyter commented Nov 29, 2023

That's unexpected.

In this case its building the badges that's causing the issue, which technically you don't need for scc.

I have pushed a fix into master which should resolve this. If you are able to confirm ill craft a new point release to ensure you can use that.

@boyter boyter added the bug Something isn't working label Nov 29, 2023
@Biswa96
Copy link
Author

Biswa96 commented Nov 30, 2023

Thank your for quick response. I have verified that e1519e0 commit fixes the build failure with 32 bit golang toolchain. From the perspective of MSYS2 project, it is not necessary to create a new release.

@boyter
Copy link
Owner

boyter commented Nov 30, 2023

Neat. Ill close this out then. Sorry about that.

@boyter boyter closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants