-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blanks are not counted correctly in Java #73
Comments
Does not appear to be related to #72 as the file is UTF-8 encoded. |
Issue is the following line,
The " is being picked up as the start of a string which is throwing out the count. Because In this case we could check for \ before the string since this should only occur inside a char. However not all languages work like that. I think this is acceptable for the moment as a quick fix though and to create a new issue to evaluate how this works in other languages. It should work for most of the common languages though which is a good short term win. |
Fix for this case exists on branch #75
NB complexity goes up because it spends time in the code state now which triggers that logic. |
Merged into master. This will still need work to make it more flexible, so no release till that is done in #76 That said closing down because if you build from master its all fine now and will make it into the next release. |
Describe the bug
In some cases blank lines are not counted correctly in Java files.
I've simplified the example somewhat, but could not pinpoint problematic lines.
To Reproduce
Expected behavior
Actual behavior
Desktop
The text was updated successfully, but these errors were encountered: