Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Stop Job Logic #41

Closed
boyter opened this issue Dec 8, 2016 · 2 comments
Closed

Improve Stop Job Logic #41

boyter opened this issue Dec 8, 2016 · 2 comments
Assignees
@boyter
Labels
bug

Comments

@boyter
Copy link
Owner

boyter commented Dec 8, 2016

The current logic to pause/stop jobs is a little hairy and not brilliant. It has issues stopping jobs when they are running and leaves open file handles. Need to resolve this.
@boyter boyter mentioned this issue Feb 19, 2017
Open
@boyter boyter mentioned this issue Mar 20, 2017
Closed
@boyter boyter added the bug label Mar 21, 2017
@boyter boyter mentioned this issue May 2, 2017
Closed
@boyter
Copy link
Owner Author

boyter commented May 2, 2017

TODO - Store pending deletes in a persistant queue and apply it on startup.

@boyter boyter self-assigned this May 2, 2017
@boyter
Copy link
Owner Author

boyter commented May 3, 2017

Implemented in branch issue41 verified with 15000 queued deletions as a stress test. Seemed to work fine and is a bit of an edge case, I would not expect someone to add 15,000 repos and then delete them. Might be worth adding a total reset option into the UI somewhere that resets everything.

Going to merge in and close down.

@boyter boyter closed this as completed May 3, 2017
boyter added a commit that referenced this issue Jun 14, 2017
@boyter
Release version 1.3.10
3042d04 
 - BREAKING CHANGE Changed validation of repository names such that they must be alphanumeric, _ or - with client and server side validation
 - BREAKING CHANGE Fix spelling of check_filerepo_chages to check_filerepo_changes for properties file
 - Set follow symlinks to be configurable through properties file #99
 - Clicking Remove will also clear the text box filters #98
 - Improved stop/reset jobs logic, deleted jobs persist on searchcode restart #41
 - Add logic to calculate project stats by lines not files and display next to existing #103
 - Deep guess logic added to guess a files type based on keyword heuristic's #105
 - Additional languages added to classifier database, F#, Mathematica, Parrot, Puppet, Rakefile, PKGBUILD, Cargo, Lock, License
 - API auditing via logs added #57
 - Search results now have RSS feed #114
 - Can add custom HTML/CSS/JS to all pages #107
 - Add average index time seconds to repo overview page #118
 - Fix bug where unable to filter on html page #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boyter boyter

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boyter