Handle the case when listing namespaces is forbidden #42
Conversation
Ignore a forbidden error as that means we can connect to the api server Do not try to watch at cluster level when we only need one namespace Fixes boz#12
|
Looks great @carlossg, thank you. I'll play around with it shortly. |
There was a problem hiding this comment.
Sorry for the delay; I've been off the grid.
I like the change, and would love to fix #12, my only hesitation is that it breaks the current behavior if the namespace does not exist yet - it currently watches for namespaces to appear.
I think adding a flag to force the behavior in this patch might be the best route. I'll try to think of a decent name this evening. I'm open to flag name suggestions or any other ideas to get #12 fixed.
Thanks for getting this moving!
|
maybe we just need to check if the namespace exists, and if so, watch only that one. |
to keep existing behavior if the namespace does not exist we watch namespaces to wait for it
|
this should work out that case |
|
Is this feature ready to be merged? |
|
I've been using it for weeks, just waiting for @boz to approve |
|
Thank you so much. Sorry for the delay. |
Ignore a forbidden error as that means we can connect to the api server
Do not try to watch at cluster level when we only need one namespace
Fixes #12