Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Golang 1.18 #72

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Add support for Golang 1.18 #72

merged 4 commits into from
Nov 14, 2022

Conversation

mnaser
Copy link
Collaborator

@mnaser mnaser commented Aug 16, 2022

The following takes care of making this build on recent version of Golang. It depends on the following:

boz/kcache#6

Once that is merged and a new release is tagged, I can (or any of the maintainers can feel free to) remove the replace and point towards the latest before landing this.

Related: #68

@mnaser mnaser mentioned this pull request Aug 16, 2022
@mnaser
Copy link
Collaborator Author

mnaser commented Sep 1, 2022

@boz small friendly ping on this, we've been using this internally for a while and it's working great.

if you're too busy, I'm happy to be added as a maintainer for both of these repos to help continue to maintain kail since it's a super useful tool in my (and my teams) toolset.

@mnaser
Copy link
Collaborator Author

mnaser commented Sep 13, 2022

I'd really like to avoid potentially forking kail -- would it be possible to be added as a maintainer to kcache and kail, @boz ?

@benmoss
Copy link

benmoss commented Oct 24, 2022

Thanks for doing this work @mnaser, I was also looking to use kail as a library for a project and I'm using your fork instead 😄

@mnaser
Copy link
Collaborator Author

mnaser commented Nov 12, 2022

@boz kail is instrumental in my and my teams work, would it be possible to add me as a maintainer so I can help keep the project running if you're low on bandwidth?

@boz
Copy link
Owner

boz commented Nov 14, 2022

I'm so sorry @mnaser!

I've added you as a collaborator, you're welcome to merge.

@mnaser mnaser merged commit 7714782 into boz:master Nov 14, 2022
@mnaser mnaser deleted the go/1.18 branch November 14, 2022 21:42
@mnaser mnaser restored the go/1.18 branch November 14, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants