Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes #4

Merged
merged 2 commits into from Mar 27, 2015
Merged

Minor changes #4

merged 2 commits into from Mar 27, 2015

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2015

No description provided.

@@ -46,10 +46,10 @@

<string name="firstrun_dialog_message">
DNSSetter lets you change your DNS servers. This is temporary and it will not resist if your
IP address changes or if you reboot your device.\n
IP address changes or if you reboot your operating system.\n
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep "device" here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does your app use the bootloader or the recovery for a very strange reason? Or do you prefer to use "device" for avoiding confusion/misunderstanding by introducing a confusion between hardware and software? Or is there another reason?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that reboot is more of a hardware term and is more commonly used with device instead of operating system, but I may be mistaken.
If you really insist, why not use "restart your operating system"?

@bparmentier bparmentier mentioned this pull request Mar 24, 2015
@ghost
Copy link
Author

ghost commented Mar 27, 2015

Done.

bparmentier added a commit that referenced this pull request Mar 27, 2015
@bparmentier bparmentier merged commit d460937 into bparmentier:master Mar 27, 2015
@ghost ghost deleted the minor branch March 27, 2015 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant