Initial icon support... #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Displaying of icons in Group browser - Displaying of icons in Entry activities - Initial icon picker - Icon picker implementation in EntryEditActivity - Rename and change of GroupCreateDialog to GroupEditActivity - Icon picker implementation in GroupEdit Activity ToDo: - Support to set icon id when creating group. - Add support to edit existing groups.
…with Eclipse Galileo 3.5 and Java 1.6.0_21-b07
Note, that icon is a blank placeholder for now.
…nd reexpose search menu option.
|
Merging in now |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brian...
This is the initial icon support. Only thing missing is the apple-icon. Not sure about any copyright issues yet, so that one is a blank icon.
Also not sure if i screwed up the rebase from your last 3 commits...
I used this Fork Queue thing to pull it in. Not sure if this is the propper way of doing it.
Guess you can ommit these 3 commits as i got them from your repository in the first place.
Alas have a look and let me know what you think.
Bests,
Tobias