Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return metadataUrl #80

Merged
merged 2 commits into from
May 20, 2021
Merged

return metadataUrl #80

merged 2 commits into from
May 20, 2021

Conversation

gwendall
Copy link
Contributor

No description provided.

@bpierre
Copy link
Owner

bpierre commented May 20, 2021

Nice! Could you please also update the README? https://github.com/spectrexyz/use-nft#usenftcontract-string-tokenid-string-nftresult

Thanks 🙏

@bpierre
Copy link
Owner

bpierre commented May 20, 2021

I’ve also been wondering if we should put somewhere all the extra data retrieved from the various JSON formats, maybe in rawMetadata or something. I imagine that’s why you need the URL?

@gwendall
Copy link
Contributor Author

Done, thanks for the lib ! 🙌
Yes, returning the raw data could be useful, rawMetadata or metadataRaw would be good names.

@bpierre bpierre mentioned this pull request May 20, 2021
Closed
@bpierre bpierre merged commit f7e5428 into bpierre:main May 20, 2021
@bpierre
Copy link
Owner

bpierre commented May 20, 2021

Cool, I opened an issue: #82

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwendall @bpierre