Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform a shallow clone in the git provider for faster startup #70

Merged
merged 1 commit into from
Jan 19, 2019

Conversation

jawher
Copy link
Contributor

@jawher jawher commented Jan 15, 2019

Running katafygio for a couple of months on rather active cluster
results in a huge git repo.

On startup, katafygio clone the git repository, which in our case was
very slow, exceeding the configured deadlines.

This PR propose to perform a shallow clone with a depth of 1: katafygio
doesn't need to full history to work, and the startup is much snappier.

Running katafygio for a couple of months on rather active cluster
results in a huge git repo.

On startup, katafygio clone the git repository, which in our case was
very slow, exceeding the configured deadlines.

This PR propose to perform a shallow clone with a depth of 1: katafygio
doesn't need to full history to work, and the startup is much snappier.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.651% when pulling 6bfebe6 on jawher:do-shallow-clone into 7b0af9e on bpineau:master.

@obourgain
Copy link

👍 need this

@bpineau bpineau merged commit 988edd4 into bpineau:master Jan 19, 2019
@bpineau
Copy link
Owner

bpineau commented Jan 19, 2019

Makes sense, thanks a lot Jawher!
Need a new release+image right now or did you already built yours?
Speaking of ever growing repository, I wonder whether we should offer the option to batch commits (ie. group and commit changes every n seconds)? Worth noting: filtering irrelevant objects (pods, replicasets, events, endpoints, ...) lowers the churn.

@jawher jawher deleted the do-shallow-clone branch January 21, 2019 08:38
@jawher
Copy link
Contributor Author

jawher commented Jan 21, 2019

Thanks for merging this so quickly 👍

Need a new release+image right now or did you already built yours?

For the time being we are using a custom built image with a patched version.
No pressure though, we'll switch back as soon as you release a new version.

Speaking of ever growing repository, I wonder whether we should offer the option to batch commits (ie. group and commit changes every n seconds)

Sure, could be handy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants