Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple DIs from business Objects #1472

Closed
Tracked by #1443
marstamm opened this issue Jul 30, 2021 · 0 comments · Fixed by #1473
Closed
Tracked by #1443

Decouple DIs from business Objects #1472

marstamm opened this issue Jul 30, 2021 · 0 comments · Fixed by #1473
Assignees
@marstamm
Labels
enhancement New feature or request

Comments

@marstamm
Copy link
Contributor

marstamm commented Jul 30, 2021 •
edited by nikku
Loading

What should we do?

Remove the 1:1 connection between business Objects and DIs

Why should we do it?

The bpmn standard allows multiple DIs (in different Diagrams) to exist for the same BPMN element. With the limitation of 1 di per BO, we prevent imports of multiple diagrams.

Therefore we should

  • Remove the link of BO -> di
  • Keep the link from di -> BO
  • Add a link from the element/shape to the di
  • Adjust Importer, Updater, etc.

Breaking Changes

The di is no longer accessible from the business Object. It can only be accessed through the element, such as element.di or through the utility function getDi in lib/util/ModelUtil.js.

To access DI in a safe manner from a shape or connection use the lib/util/ModelUtil#getDi utility.
@marstamm marstamm mentioned this issue Jul 30, 2021
Closed
33 tasks
@marstamm marstamm changed the title business-objects are decoupled from di Decouple DIs from business Objects Jul 30, 2021
@marstamm marstamm added backlog Queued in backlog enhancement New feature or request labels Jul 30, 2021
@marstamm marstamm self-assigned this Jul 30, 2021
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Aug 5, 2021
marstamm added a commit that referenced this issue Aug 5, 2021
@marstamm
chore: fix test cases
fe3bc35 
closes #1472
marstamm added a commit that referenced this issue Aug 6, 2021
@marstamm
chore(DI): adjust Tests to use utility function
d36f05a 
closes #1472
@marstamm marstamm mentioned this issue Aug 6, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 6, 2021
marstamm added a commit that referenced this issue Aug 20, 2021
@marstamm
chore(DI): adjust Tests to use utility function
e8b578f 
closes #1472
marstamm added a commit that referenced this issue Aug 25, 2021
@marstamm
chore(DI): adjust Tests to use utility function
9904a52 
closes #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
feat: decouple DI from businessObject
df75988 
In the diagram `di` is now accessed via the diagram element, not the 
business object. This has the benefit that elements in multiple diagrams 
can easily be represented.

Related to #1472


BREAKING CHANGE:

* Instead of referencing the `di` from the business object, reference it
  from the diagram element representing it.
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
chore: adjust features to new DI structure
2bb522c 
Related to #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
test: adjust to use getDi utility function
8df0b90 
Related to #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
chore: throw error when accessing DI from business object
7eb7271 
Related to #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
feat: decouple DI from businessObject
683715d 
In the diagram `di` is now accessed via the diagram element, not the
business object. This has the benefit that elements in multiple diagrams
can easily be represented.

Related to #1472

BREAKING CHANGE:

* Instead of referencing the `di` from the business object, reference it
  from the diagram element representing it.
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
chore: adjust features to new DI structure
d9a7e44 
Related to #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
test: adjust to use getDi utility function
cf77ef0 
Related to #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
chore: throw error when accessing DI from business object
930c7c9 
Related to #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
feat: decouple DI from businessObject
d363fc0 
In the diagram `di` is now accessed via the diagram element, not the
business object. This has the benefit that elements in multiple diagrams
can easily be represented.

Related to #1472

BREAKING CHANGE:

* Instead of referencing the `di` from the business object, reference it
  from the diagram element representing it.
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
chore: adjust features to new DI structure
55258fc 
Related to #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
test: adjust to use getDi utility function
737d57c 
Related to #1472
nikku pushed a commit that referenced this issue Aug 27, 2021
@marstamm @nikku
chore: throw error when accessing DI from business object
d0a057c 
Related to #1472
marstamm added a commit that referenced this issue Aug 30, 2021
@marstamm
feat: decouple DI from businessObject
1daac19 
In the diagram `di` is now accessed via the diagram element, not the
business object. This has the benefit that elements in multiple diagrams
can easily be represented.

Related to #1472

BREAKING CHANGE:

* Instead of referencing the `di` from the business object, reference it
  from the diagram element representing it.
marstamm added a commit that referenced this issue Aug 30, 2021
@marstamm
chore: adjust features to new DI structure
6a5e1e9 
Related to #1472
marstamm added a commit that referenced this issue Aug 30, 2021
@marstamm
test: adjust to use getDi utility function
1551bd4 
Related to #1472
marstamm added a commit that referenced this issue Aug 30, 2021
@marstamm
chore: throw error when accessing DI from business object
1ec8bf9 
Related to #1472
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 3, 2021
nikku pushed a commit that referenced this issue Sep 3, 2021
@marstamm @nikku
feat: decouple DI from businessObject
2b11d87 
In the diagram `di` is now accessed via the diagram element, not the
business object. This has the benefit that elements in multiple diagrams
can easily be represented.

Related to #1472

BREAKING CHANGE:

* Instead of referencing the `di` from the business object, reference it
  from the diagram element representing it.
nikku pushed a commit that referenced this issue Sep 3, 2021
@marstamm @nikku
chore: adjust features to new DI structure
769bcbe 
Related to #1472
nikku pushed a commit that referenced this issue Sep 3, 2021
@marstamm @nikku
test: adjust to use getDi utility function
ca8488b 
Related to #1472
nikku pushed a commit that referenced this issue Sep 3, 2021
@marstamm @nikku
chore: throw error when accessing DI from business object
597c417 
Related to #1472
marstamm added a commit that referenced this issue Oct 8, 2021
@marstamm
feat: decouple DI from businessObject
4d59772 
In the diagram `di` is now accessed via the diagram element, not the
business object. This has the benefit that elements in multiple diagrams
can easily be represented.

Related to #1472

BREAKING CHANGE:

* Instead of referencing the `di` from the business object, reference it
  from the diagram element representing it.
marstamm added a commit that referenced this issue Oct 8, 2021
@marstamm
chore: adjust features to new DI structure
8ecc37d 
Related to #1472
marstamm added a commit that referenced this issue Oct 8, 2021
@marstamm
test: adjust to use getDi utility function
dcadffd 
Related to #1472
marstamm added a commit that referenced this issue Oct 8, 2021
@marstamm
chore: throw error when accessing DI from business object
b27e462 
Related to #1472
@ps91 ps91 mentioned this issue Mar 4, 2022
Closed
@pme123 pme123 mentioned this issue Jul 7, 2022
Open
barmac added a commit to barmac/camunda-modeler-plugin-color-picker that referenced this issue Aug 29, 2022
@barmac
fix: use getDi for Camunda Modeler 5 compatibility
8bdaf8e 
Related to bpmn-io/bpmn-js#1472
Closes camunda-community-hub#2
@barmac barmac mentioned this issue Aug 29, 2022
Merged
gclaussn added a commit to camunda-community-hub/bpmn-driven-testing that referenced this issue Feb 11, 2023
@gclaussn
fix: fixed interaction with process element and related business obje…
8d496ed 
…ct due to bpmn-io/bpmn-js#1472
gclaussn added a commit to camunda-community-hub/bpmn-driven-testing that referenced this issue Feb 11, 2023
@gclaussn
fix: fixed interaction with process element and related business obje…
17a602b 
…ct due to bpmn-io/bpmn-js#1472
@sombrek sombrek mentioned this issue Apr 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring: decouple DI from businessObject bpmn-io/bpmn-js
1 participant
@marstamm