fix(popup-menu): improve set off from background #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
force-pushed
the
improve-popup-menu-setoff
branch
from
e5aae6a
to
a4200cd
Compare
smbea
reviewed
Jan 24, 2023
| width: min-content; | ||
| background: var(--popup-background-color); | ||
| overflow: hidden; | ||
| position: absolute; | ||
|
|
||
| box-shadow: 0px 2px 10px var(--popup-shadow-color); | ||
| box-shadow: 0px 2px 6px var(--popup-shadow-color); | ||
| border: solid 1px var(--popup-border-color); |
There was a problem hiding this comment.
Doesn't a transparent border does the same thing as a padding?
There was a problem hiding this comment.
Maybe.
But honestly padding was not my intention here. I simply wanted to make it possible for people to create borders if they need them (for accessibility reasons), cf. bpmn-io/bpmn-js#1812 (comment).
smbea
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to bpmn-io/bpmn-js#1812