Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Additional Information when Calling Reporter#report #75

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Mar 16, 2022

Provide additional information by providing object as third argument.

Example

Reporter.report('foo', 'Foo error', [ 'foo', 'bar', 'baz' ]);

Reporter.report('foo', 'Foo error', {
  path: [ 'foo', 'bar', 'baz' ],
  foo: 'foo'
});

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 16, 2022
@CLAassistant
Copy link

CLAassistant commented Mar 16, 2022

CLA assistant check
All committers have signed the CLA.

@philippfromme philippfromme marked this pull request as ready for review March 16, 2022 13:24
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 16, 2022
@philippfromme philippfromme changed the title WIP Provide Additional Information when Calling Reporter#report Mar 16, 2022
Copy link

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fake-join fake-join bot merged commit bf9f5cf into master Mar 16, 2022
@fake-join fake-join bot deleted the 74-additional-information branch March 16, 2022 13:59
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 16, 2022
@philippfromme
Copy link
Contributor Author

@nikku You might want to have a look. 👀 I thought I'd added you as a reviewer. 🤔

@nikku
Copy link
Member

nikku commented Mar 16, 2022

Good thing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants