Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can set the expression language #240

Closed
philippfromme opened this issue Nov 1, 2017 · 4 comments
Closed

I can set the expression language #240

philippfromme opened this issue Nov 1, 2017 · 4 comments
Assignees
Milestone

Comments

@philippfromme
Copy link
Contributor

No description provided.

@philippfromme philippfromme added this to the Backlog - Rewritten dmn-js milestone Nov 6, 2017
@philippfromme philippfromme modified the milestones: Backlog - Rewritten dmn-js, DM10 Dec 11, 2017
@nikku nikku added the ready Ready to be worked on label Jan 16, 2018
@nikku nikku modified the milestones: DM10, DM11 Jan 25, 2018
@nikku nikku removed the ready Ready to be worked on label Jan 25, 2018
@philippfromme philippfromme self-assigned this Jan 26, 2018
@philippfromme philippfromme added in progress Currently worked on ready Ready to be worked on and removed in progress Currently worked on labels Jan 26, 2018
@philippfromme philippfromme added in progress Currently worked on needs review Review pending and removed ready Ready to be worked on in progress Currently worked on labels Feb 12, 2018
@philippfromme philippfromme assigned nikku and unassigned philippfromme Feb 12, 2018
@philippfromme
Copy link
Contributor Author

There is one test case that I wasn't able to get running due to decision table modeling not overriding table modeling in the injector. Maybe you can help me with that.

@nikku
Copy link
Member

nikku commented Feb 12, 2018

As a general good practice we don't depend depend on modeling in other bpmn.io projects directly like you do here.

Instead, the correct modeling is provided as part of the test and the respective editor(s). You need to track down which module depends on table-js/lib/features/modeling and may force its use (a quick search reveals cut-paste and editor-actions are good candidates).

If we want to avoid these kinds of errors we'd need to rework the way we require the modeling layer as described above.

@nikku nikku assigned philippfromme and unassigned nikku Feb 12, 2018
@nikku nikku added in progress Currently worked on and removed needs review Review pending labels Feb 12, 2018
@philippfromme
Copy link
Contributor Author

Okay, yeah, cut-paste is the problem here. I will then refactor everything to not depend on modeling.

@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Feb 14, 2018
@philippfromme philippfromme assigned nikku and unassigned philippfromme Feb 14, 2018
@nikku
Copy link
Member

nikku commented Feb 14, 2018

Seems like the latest changes break the context-menu apperance:

image

@nikku nikku added in progress Currently worked on and removed needs review Review pending labels Feb 14, 2018
@nikku nikku added needs review Review pending and removed in progress Currently worked on labels Feb 19, 2018
@nikku nikku closed this as completed in 369e045 Feb 19, 2018
@ghost ghost removed the needs review Review pending label Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants