Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed FEEL editor in Table cells #774

Closed
6 of 8 tasks
Tracked by #733
barmac opened this issue Sep 13, 2023 · 1 comment · Fixed by #779
Closed
6 of 8 tasks
Tracked by #733

Embed FEEL editor in Table cells #774

barmac opened this issue Sep 13, 2023 · 1 comment · Fixed by #779
Assignees

Comments

@barmac
Copy link
Member

barmac commented Sep 13, 2023

  • Table cell is a FEEL editor
  • Table cell is a plain input if expression language is different than FEEL
  • Escape blurs the input
  • I can select suggestion with Enter
  • I can select suggestion with mouse click
  • Performance is acceptable even in a big table
    • FEEL editor is embedded only for active cell
  • Focussed cell changes when use navigates cells with keyboard (tab, enter)
@barmac barmac mentioned this issue Sep 13, 2023
4 tasks
@barmac barmac self-assigned this Sep 13, 2023
@barmac barmac added the ready Ready to be worked on label Sep 13, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Sep 15, 2023
@barmac
Copy link
Member Author

barmac commented Sep 20, 2023

I was able to fix most of the interactions.
However, one of the fixes breaks the autosuggestion choice in the input expression. So that's what needs to be fixed yet.

barmac added a commit that referenced this issue Sep 22, 2023
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 22, 2023
barmac added a commit that referenced this issue Sep 22, 2023
barmac added a commit that referenced this issue Sep 22, 2023
barmac added a commit that referenced this issue Sep 22, 2023
barmac added a commit that referenced this issue Sep 25, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant