Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make add column buttons focussable #869

Merged
merged 2 commits into from
May 24, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented May 23, 2024

Closes #847

@barmac barmac requested review from a team, philippfromme and holygeek00 and removed request for a team May 23, 2024 14:13
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 23, 2024
@barmac barmac changed the base branch from develop to main May 24, 2024 07:00
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is technically focusable now I'd consider to fine-tune the styling a little bit:

capture bGVPMP_optimized

One way to do it to add an outline-offset: 4px;, resulting in this:

capture GTD6YX_optimized

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels May 24, 2024
@barmac
Copy link
Member Author

barmac commented May 24, 2024

Indeed, the outline looks invisible on your screencast. In my browser (Chrome on Mac), it is easily distinguishable. I double-checked and it's also not visible without a magnifying glass o.O

@barmac
Copy link
Member Author

barmac commented May 24, 2024

I've added the change from your suggestion.

@barmac barmac requested a review from nikku May 24, 2024 13:02
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 24, 2024
@barmac
Copy link
Member Author

barmac commented May 24, 2024

Thanks for checking.

image

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🍰

@barmac barmac merged commit 8da7d01 into main May 24, 2024
8 checks passed
@barmac barmac deleted the 847-make-new-column-buttons-focussable branch May 24, 2024 14:46
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot focus "add column" button
2 participants