Add snippet suggestions for BKM #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
requested review from
a team,
philippfromme,
marstamm and
nikku
and removed request for
a team
barmac
force-pushed
the
827-snippet-suggestion-bkm
branch
from
6ac2999
to
96d2032
Compare
barmac
force-pushed
the
827-snippet-suggestion-bkm
branch
from
96d2032
to
56905c8
Compare
|
Works great. Stumbled again over #838, which should be a simple follow-up fix #838 (comment). Stumbled over an UX issue: #875. |
nikku
approved these changes
May 27, 2024
|
Makes sense, thanks for the review and reporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-05-27.at.09.40.19.mov
@bpmn-io/feel-editor@1.4.0@bpmn-io/dmn-variable-resolver@0.7.0Closes #785
Closes #827