-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable users to configure multiline text inputs #283
Comments
@pinussilvestrus @christian-konrad Please share your opinion on option 1 vs option 2. This is realistically the only prep required for an implementation of this, and it could most likely be implemented in a few hours, which is a quick win :) |
Is there a sketch somewhere? Because some questions came to my mind:
Personally, I'd vote for having another form component. Rationale: My assumption is that linting the support will be much easier in the Modeler products when it is just another component and not a property in an existing form field. |
It will result in a text-area element yes, tis the proper way. While I understand the rationale behind the linting simplicity, one of the problems is that we can't apply this to every single change of control that we do otherwise we'll end up with 25 by the end of the year. I don't think we can use linting simplicity as a baseline, for example thinking about floating point numbers this one is much clearer, we will want it to be the same control as integers. But following this logic it'd have to be different. I think this one has more merit to be an independent control, but still I'm not so certain :/ Regarding configuration, that's up to us but pretty easy to set up. I would opt for two configurations, |
Related: #194 |
Is your feature request related to a problem? Please describe
As part of our initiative to enable more use cases in form-js, we want to allow users to enter larger chunks of text via a multi-line text component.
Describe the solution you'd like
There are two main ways we can consider implementing this:
Solution 1 is the fastest way to do this, the downside relative to solution 2 would be that multi-line is a different html component, and so it might make sense to have that difference represented in the palette as well. It also make the base component for text a tiny bit more complex, but honestly it's minor.
I would prefer solution 1, it avoids quite a bit of overhead and I also think it makes sense for a form developer.
Additional context
Product hub issue
The text was updated successfully, but these errors were encountered: