Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground JSON Validation #386

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Playground JSON Validation #386

merged 3 commits into from
Nov 14, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Nov 4, 2022

Related to camunda/form-playground#20

  • Incorporate lang-json JSON parse linter
  • Emit formPlayground.inputDataError so that integrators can react to parsing errors

Demo: https://demo-json-validation--camunda-form-playground.netlify.app/

image

image

@pinussilvestrus pinussilvestrus force-pushed the json-validation branch 2 times, most recently from 22456c6 to 4eb726f Compare November 7, 2022 15:11
@pinussilvestrus
Copy link
Contributor Author

@christian-konrad @RomanKostka can we merge that?

Copy link
Contributor

@Skaiir Skaiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, tested and insane value. Nice one :)

@pinussilvestrus
Copy link
Contributor Author

Let's merge this 👍 already talked with @RomanKostka, looks fine 👍

@pinussilvestrus pinussilvestrus merged commit a9a58e4 into develop Nov 14, 2022
@pinussilvestrus pinussilvestrus deleted the json-validation branch November 14, 2022 08:23
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants