FEEL for Labels and Descriptions #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
11e8967
to
dbdeb32
Compare
pinussilvestrus
changed the title
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
dbdeb32
to
2f0b8c5
Compare
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
2f0b8c5
to
5d840d1
Compare
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
5d840d1
to
50cd400
Compare
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
50cd400
to
200148c
Compare
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
This was referenced May 22, 2023
pinussilvestrus
force-pushed
the
653-readonly-expressions
branch
2 times, most recently
from
9a8b54d
to
e79c1eb
Compare
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
200148c
to
15fe7ad
Compare
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
15fe7ad
to
ff52b7e
Compare
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
ff52b7e
to
2542a4a
Compare
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
bpmn-io-tasks
bot
added
needs review
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
pinussilvestrus
requested review from
Skaiir,
vsgoulart,
christian-konrad and
RomanKostka
christian-konrad
approved these changes
May 25, 2023
vsgoulart
reviewed
May 25, 2023
packages/form-js-editor/src/features/expression-language/EditorTemplating.js
Outdated
Show resolved
Hide resolved
packages/form-js-editor/src/features/properties-panel/entries/LabelEntry.js
Outdated
Show resolved
Hide resolved
We did: https://github.com/bpmn-io/form-js/pull/658/files#diff-858e82fabb9777bd462c5309760e5a499dc699b9a880787f45d6a3b6657223a9. There are also test cases at the end. |
pinussilvestrus
force-pushed
the
653-labels-descriptions-others
branch
from
2542a4a
to
6fbd14d
Compare
github-actions
bot
temporarily deployed
to
demo-653-labels-descriptions-o
vsgoulart
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #653
Adds FEEL support for
labelanddescription.Demo: https://demo-653-labels-descriptions-o--camunda-form-playground.netlify.app/