Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix visual regression integration linking #714

Merged
merged 1 commit into from
Jul 13, 2023
Merged

test: Fix visual regression integration linking #714

merged 1 commit into from
Jul 13, 2023

Conversation

vsgoulart
Copy link
Contributor

@pinussilvestrus I think one of the reasons the tests weren't very reliable some weeks ago is because I forgot to link changes in the Carbon custom styles

@vsgoulart
test: Fix visual regression integration linking
62a7176 
@pinussilvestrus I think one of the reasons the tests weren't very reliable some weeks ago is because I forgot to link changes in the Carbon custom styles
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 13, 2023
pinussilvestrus
pinussilvestrus approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I guess we were a bit lucky that it didn't crash more often without 😄

@vsgoulart vsgoulart changed the base branch from develop to master July 13, 2023 12:33
@vsgoulart vsgoulart changed the base branch from master to develop July 13, 2023 12:33
@vsgoulart vsgoulart merged commit 00c0448 into develop Jul 13, 2023
7 of 11 checks passed
@vsgoulart vsgoulart deleted the fix-visual-integration branch July 13, 2023 12:34
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 13, 2023
@pinussilvestrus pinussilvestrus restored the fix-visual-integration branch July 13, 2023 12:34
@pinussilvestrus pinussilvestrus deleted the fix-visual-integration branch July 13, 2023 12:34
@pinussilvestrus
Copy link
Contributor

I think we need to update the playwright image as well 😓 https://github.com/bpmn-io/form-js/actions/runs/5543067140/jobs/10118582951

@vsgoulart
Copy link
Contributor Author

I think we need to update the playwright image as well sweat https://github.com/bpmn-io/form-js/actions/runs/5543067140/jobs/10118582951

@pinussilvestrus Yeah, my bad
I saw the wrong CI result I updated it here #715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

@Skaiir Skaiir Awaiting requested review from Skaiir

Assignees

@vsgoulart vsgoulart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsgoulart @pinussilvestrus