Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the TreeWalker from ImportHandler #146

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Conversation

yT0n1
Copy link
Collaborator

@yT0n1 yT0n1 commented Nov 20, 2019

Make the TreeWalker accessible via Viewer. This way a tool that uses chor-js can replace the walker with a different implementation.

… Viewer. This way a tool that uses chor-js can replace the walker with a different implementation.
Copy link
Member

@jan-ladleif jan-ladleif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

lib/import/ChoreoTreeWalker.js Outdated Show resolved Hide resolved
@yT0n1 yT0n1 merged commit 0afbb4c into master Nov 22, 2019
@yT0n1 yT0n1 deleted the decouple-tree-walker branch November 22, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants