Fix sequence flow connection #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uence flows, due to an api change in bpmn-js. Also restructure and slightly update the rules. Now it should be clearer which rules are from chor-js and which are copied from bpmn-js and should behave like these, except for the self calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What seemed to be initially one bug introduced by the upgrade to bpmn-js 6 where actually two bugs. However, what they both had in common was that they resulted from our unclean management of ChoreoRules.js. I cleaned it up, fixed the bugs and left some comments so this will not happen so easily in future.
The diff looks hard to read, however, I just moved all the rules overwriting bpmn-js to the top.