Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DI ordering on export #164

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Add DI ordering on export #164

merged 3 commits into from
Oct 29, 2020

Conversation

yT0n1
Copy link
Collaborator

@yT0n1 yT0n1 commented Sep 1, 2020

Fixes #159. This is really a bit of a workaround. Ultimately it would be nicer if it could be fixed in bpmn-moddle. However, I tried to implement it with a minimum amount of invasiveness. The issues are not only the participant bands as originally thought, but also our option to have multiple diagrams in one file. Both problems should be solved, however.

@yT0n1
Copy link
Collaborator Author

yT0n1 commented Sep 1, 2020

@jan-ladleif If you still have access to Trisotech, could you check if the diagram roundtrip works. I think Trisotech was the editor that started the change for bpmn-js in the first place.

@jan-ladleif
Copy link
Member

@jan-ladleif If you still have access to Trisotech, could you check if the diagram roundtrip works. I think Trisotech was the editor that started the change for bpmn-js in the first place.

My trial has expired, unfortunately. 😄

@jan-ladleif jan-ladleif merged commit 8239b9c into master Oct 29, 2020
@jan-ladleif jan-ladleif deleted the feat/di-ordering branch October 29, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor Ordering of DI for xml
2 participants