You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Updates to the y values of a Lines mark (fill inside 2 lines) changes the min and max of x and y scales. No matter how I specify the max y-value of the scale, the Lines mark ignores that limit and is allowed to extend beyond the fixed heatmap.
Expected behavior
As the slider changes, the Lines mark should become thicker (as the slider value corresponds to the number of diagonals to include in the red window) but not change the original axis range (i.e. of the heatmap). The Lines mark should stay within the Figure bounds of [0, 278] at all times.
Screenshots
Additional context
Setting apply_clip=True and preserve_domain: {'x': True, 'y': True} to the Mark also doesn't limit the Lines mark to the domain specified when creating the scales. Have tried the suggested fix from #880 (i.e. plt.ylim()) and updating the min and max attributes of the scales both inside and outside of the line.hold_sync() block. Makes no difference -- the Lines mark still ignores the specified domain.
Also, the fill between 2 lines fix is the workaround suggested in #523. I've also tried creating the fill by using fill="between" with y1 and y2 but that only works when initially plotted and no Lines mark appears when the slider is changed. Don't know if how the Lines mark is created affects this behavior at all.
Apologies in advance if I messed up anything, this is my first time contributing/reporting an issue on Github.
The text was updated successfully, but these errors were encountered:
Describe the bug
Updates to the y values of a Lines mark (fill inside 2 lines) changes the min and max of x and y scales. No matter how I specify the max y-value of the scale, the Lines mark ignores that limit and is allowed to extend beyond the fixed heatmap.
To Reproduce
Expected behavior
As the slider changes, the Lines mark should become thicker (as the slider value corresponds to the number of diagonals to include in the red window) but not change the original axis range (i.e. of the heatmap). The Lines mark should stay within the Figure bounds of [0, 278] at all times.
Screenshots
Additional context
Setting
apply_clip=True
andpreserve_domain: {'x': True, 'y': True}
to the Mark also doesn't limit the Lines mark to the domain specified when creating the scales. Have tried the suggested fix from #880 (i.e.plt.ylim()
) and updating the min and max attributes of the scales both inside and outside of theline.hold_sync()
block. Makes no difference -- the Lines mark still ignores the specified domain.Also, the fill between 2 lines fix is the workaround suggested in #523. I've also tried creating the fill by using
fill="between"
withy1
andy2
but that only works when initially plotted and no Lines mark appears when the slider is changed. Don't know if how the Lines mark is created affects this behavior at all.Apologies in advance if I messed up anything, this is my first time contributing/reporting an issue on Github.
The text was updated successfully, but these errors were encountered: