Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AS Build Mode Not Detected #2

Closed
timbnr opened this issue Apr 5, 2022 · 3 comments
Closed

AS Build Mode Not Detected #2

timbnr opened this issue Apr 5, 2022 · 3 comments
Assignees
@tmatijevich
Labels
invalid This doesn't seem right

Comments

@timbnr
Copy link

timbnr commented Apr 5, 2022

AS build mode is not detected when I use the pre-build script. All other fields are populated. See screenshots:

image
image
@tmatijevich tmatijevich self-assigned this Apr 6, 2022
@tmatijevich tmatijevich added the invalid This doesn't seem right label Apr 6, 2022
@tmatijevich
Copy link
Collaborator

That's interesting. Thanks for pointing it out.
Quick isolation test can be echo Mode: $(AS_BUILD_MODE) in the pre- or post-build event fields.
In the latest version of AS I get Mode: Rebuild.
Previous but recent versions of AS I get Mode: $(AS_BUILD_MODE).
Finally, in older versions of AS I get Mode: Rebuild again.
Appears to have broke for a period of time and is now fixed - I'll catch $(AS_BUILD_MODE) and replace with Unknown.

tmatijevich added a commit that referenced this issue Apr 6, 2022
@tmatijevich
AS_BUILD_MODE macro in unavailable in some AS/AR versions. Catch the …
eee6ff5 
…unreplaced macro with "Unknown" to avoid build warnings for "$" and confusion. Addresses #2
tmatijevich added a commit that referenced this issue Apr 6, 2022
@tmatijevich
Check all macros for incomplete replacement addressing #2
ebdfba4
@tmatijevich
Copy link
Collaborator

tmatijevich commented Apr 6, 2022 •
edited
Loading

This has further issues because $ is an escape character in IEC declarations.
If this package initializes with $ characters, a build can result is several 1287 "<characters> are replaced by <characters>" warnings (using $ with non-special characters).
Now I'm checking all macros arguments for incompletion.

@tmatijevich
Copy link
Collaborator

Exceptions should be handled now in 0.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmatijevich tmatijevich

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timbnr @tmatijevich