Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint@3.x support not possible until brackets update bundled node version to 4.x #36

Closed
sradevski opened this issue Jul 11, 2016 · 20 comments

Comments

@sradevski
Copy link

sradevski commented Jul 11, 2016

The extension cannot load the eslint client. I tried installing eslint globally and locally, both running fine, but when run from Brackets.io it cannot load the client. I am running brackets on MacBook Pro, El Capitan.

@AdriVanHoudt
Copy link

I am having the same issue here. I think this has to do with eslint 3 requiring node >= 4, @zaggino any suggestions on how this could be solved? Seems like Brackets needs to update it's internal version of node or could this plugin do this?

@zaggino
Copy link
Member

zaggino commented Jul 11, 2016

hmm, extension probably won't be able to do anything with this, it's brackets problem

@AdriVanHoudt
Copy link

do you know if brackets has an initiative to up the node version?

@zaggino
Copy link
Member

zaggino commented Jul 12, 2016

@AdriVanHoudt I don't believe brackets have an initiative to do anything except get the brackets code to new dreamweaver at the moment, atom or vs-code might be better alternatives at the moment

zaggino added a commit that referenced this issue Jul 12, 2016
@AdriVanHoudt
Copy link

new dreamweaver? Also I just updated and it works again, I think it i fine as long as my config does not include eslint > 3 rules

@AdriVanHoudt
Copy link

Ok so it works when my project also has an eslint of < 3 :/

@zaggino
Copy link
Member

zaggino commented Jul 13, 2016

@AdriVanHoudt
Copy link

Hmm feels like the project is slightly dying out seeing how old that is and looking at the recent commits, which are mostly translation updates

@zaggino
Copy link
Member

zaggino commented Jul 30, 2016

@sradevski @AdriVanHoudt published brackets-eslint@2.6.0

i put a check if it detects eslint@3.x, then fallback to use latest eslint@2.x instead of failing completely

only thing I could think of: e2c2aa3

@zaggino zaggino changed the title cannot call 'executeOnText' on undefined (cannot load Client) eslint@3.x support not possible until brackets update bundled node version to 4.x Jul 30, 2016
@AdriVanHoudt
Copy link

AdriVanHoudt commented Aug 1, 2016

@zaggino I am not seeing the plugin in npm registry (brackets plugin) any more, I can see it in the plugins thing but that is v 0.17 and it does not allow me to install it. Any way you unpublished it or something?

@zaggino
Copy link
Member

zaggino commented Aug 1, 2016

@AdriVanHoudt Nothing is unpublished, registry builder uses npmsearch.com site to search for extensions but it seems quite unreliable. Must look at some other npm search provider.

@AdriVanHoudt
Copy link

ah I see, weird that it can't find just that one, no way you can use npm's api (if they have one)?

@zaggino
Copy link
Member

zaggino commented Aug 1, 2016

They don't, not that I know of. I'll try to get it up and running somehow.

@AdriVanHoudt
Copy link

@zaggino thanks a lot for the effort! 🔥

@zaggino
Copy link
Member

zaggino commented Aug 2, 2016

@AdriVanHoudt pushed out new server version of brackets-npm-registry using actual urls that npm itself calls (by debugging the client) and brackets-eslint is back in there ;)

@AdriVanHoudt
Copy link

@zaggino seems to work now! Now since the last eslint release it messed something up with the indent so I needed to add a config to the rule which eslint 2 does not like :( dumb that v2 does not just ignore it
hopefully brackets will update to node 4 or up. If there is no intention to I might switch IDE sadly

@zaggino
Copy link
Member

zaggino commented Aug 5, 2016

@AdriVanHoudt doing progress of getting new node (and eslint 3.x support with it) into brackets: adobe/brackets#12647

@AdriVanHoudt
Copy link

@zaggino following it and looks great!

@zaggino
Copy link
Member

zaggino commented Aug 31, 2016

@AdriVanHoudt this is now fixed in https://github.com/zaggino/brackets-electron/releases
still waiting for the team to approve changes to land in regular brackets too

@zaggino
Copy link
Member

zaggino commented Sep 19, 2016

Latest pre-release of Brackets supports this too: https://github.com/adobe/brackets/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants