Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::memcpy -> memcpy #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

socram8888
Copy link
Contributor

Current code is causing compilation errors in Debian bookworm. Replacing std::memcpy with just memcpy (as the rest of the memcpy calls are) fixed the issue.

builder.cc: In function ‘void createImage(ImageSettings, const uint8_t*, uint32_t)’:
builder.cc:693:14: error: ‘memcpy’ is not a member of ‘std’; did you mean ‘wmemcpy’?
  693 |         std::memcpy(out.data() + out.size() / 2, out.data(), out.size() / 2);
      |              ^~~~~~
      |              wmemcpy

@alex-free
Copy link

Duplicate of #97

@alex-free
Copy link

alex-free commented Nov 24, 2022

Actually I don't know what's better. I initially did the same thing for my pull request but then realized I could just add #include cstring to fix it and settled on that.

@socram8888
Copy link
Contributor Author

Not sure. There's only one std::memcpy and plenty of regular memcpy in that file, so I guessed this one was a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants