Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify tagalong headers for multipart uploads #40

Merged

Conversation

wyozi
Copy link
Contributor

@wyozi wyozi commented May 15, 2024

When trying to do a multipart upload with customer provided encryption keys, the upload fails with "The multipart upload initiate requested encryption. Subsequent part requests must include the appropriate encryption parameters."

This PR includes the required headers in individual part uploads if specified

@wyozi wyozi force-pushed the multipart-tagalong-headers branch from cd4e11a to 384fe64 Compare May 15, 2024 12:54
Copy link
Owner

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used these features myself, but I'll trust you on that :)

Code looks good, thanks.

@bradenmacdonald bradenmacdonald merged commit 5e272d6 into bradenmacdonald:main May 16, 2024
2 checks passed
@wyozi wyozi deleted the multipart-tagalong-headers branch May 16, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants