Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: add API Gets which means gets #111

Closed
wants to merge 12 commits into from
Closed

BREAKING CHANGE: add API Gets which means gets #111

wants to merge 12 commits into from

Conversation

lovelock
Copy link

@lovelock lovelock commented Dec 18, 2019

Original version of Get means gets and it breaks the compatibility of other servers which partially implement memcache protocol, and now it is fixed.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@bradfitz bradfitz self-requested a review December 20, 2019 04:11
@bradfitz
Copy link
Owner

Sorry, but having both Gets and Get with no docs explaining their difference isn't a good situation. It's also bad to have two in any case.

Your PR description also describe the problem or reference an issue.

I'm not going to look at all the commits to try to guess what problem you're fixing. Please file a bug. I'm going to close this PR for now as I'm not sure what it's about.

@lovelock
Copy link
Author

Sorry, but having both Gets and Get with no docs explaining their difference

I agree with this, but Get means gets is more confusing, isn't it? #112

@bradfitz
Copy link
Owner

I'll comment on #112. This PR isn't the right fix.

@lovelock lovelock mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants