-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: add API Gets which means gets #111
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Sorry, but having both Gets and Get with no docs explaining their difference isn't a good situation. It's also bad to have two in any case. Your PR description also describe the problem or reference an issue. I'm not going to look at all the commits to try to guess what problem you're fixing. Please file a bug. I'm going to close this PR for now as I'm not sure what it's about. |
I agree with this, but |
I'll comment on #112. This PR isn't the right fix. |
Original version of
Get
meansgets
and it breaks the compatibility of other servers which partially implement memcache protocol, and now it is fixed.