Add card rarity information to the card buffer #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rarity is now included in the same buffer item as card type. CardUtils: Added a getCardRarityString method. CardBuffer: modified the update method.
|
Sorry it took this long to get to this; I just added this to the beta2 branch. I merged this to the master branch by accident and had to revert it and due to some structural changes I had to manually implement it into the beta2 branch. Sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that it would be useful if information about card rarity (common, uncommon, rare etc.) would be available from the card buffer. However since this information is not often needed, adding it to its own item seemed unnecessary, so I added it to the same item which contained the card type. So now instead of for example "Attack type", it now contains "Attack type, uncommon rarity". I did this by adding a new getCardRarityString method to the CardUtils class and I modified the update method of CardBuffer to add the rarity information to the buffer. The rarity name is now just name of the CardRarity enum value. I don't know if there could be a way to get a localized string for the rarity if the game has that.