should not make a query for each row in non-paginated table

[jieter]

As discussed in #361, this test fails. This seems to be related to #330:

• testing with v1.2.1 makes the tests pass
• testing with v1.2.2 (Column ordering queryset passthrough #330 merged), make the test fail.

def test_single_query_for_non_paginated_table(settings):
    '''
    A non-paginated table should not generate a query for each row, but only
    one query to count the rows and one to fetch the rows.
    '''
    from django.db import connection
    settings.DEBUG = True

    for i in range(10):
        Person.objects.create(first_name='Bob %d' % i, last_name='Builder')

    num_queries_before = len(connection.queries)

    class PersonTable(tables.Table):
        class Meta:
            model = Person
            fields = ('first_name', 'last_name')
            order_by = ('last_name', 'first_name')

    table = PersonTable(Person.objects.all())

    request = build_request('/')
    RequestConfig(request, paginate=False).configure(table)
    table.as_html(request)
    # or for current master
    # print table.as_values()

    print '\n'.join(q['sql'] for i, q in enumerate(connection.queries) if i > num_queries_before)
    assert len(connection.queries) - num_queries_before == 2

SELECT queries performed:

SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 1
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 2
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 3
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 4
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 5
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 6
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 7
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 8
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 9
SELECT [...] FROM "app_person" ORDER BY "last_name" ASC, "first_name" ASC LIMIT 1 OFFSET 10

(redacted for readability)

[jieter]

bisecting points to 8fe9826, entirely my fault, not #330.

[jieter]

released 1.4.0