[feature] Type-Aware Field Matcher #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to allow identical rule output/reloading and better test comparisons.
Co-authored-by: Bradley Kemp <bradleyjkemp@users.noreply.github.com>
|
I think something odd happened, because I was silly and started working on this in my fork off of the branch that was recently merged. As such, the commit history seems to have the commits from the other merge listed. However, the diff looks just fine, so I don't think it's an issue. If the history gets wonky, we can always squash it on merge anyway. 🤷 Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to load arbitrarily typed values in a field matcher, however maintains the same evaluation logic (i.e. treating all scalar types as strings and ignoring non-scalar typed values). This includes scalar values like integers, strings and floats as well as complex values which lie outside the scope of the Sigma specification, but could be helpful in extensions during parsing or evaluation of rules using this library.
Given your response to the issue I created, it seems you're open to these changes, so I figured I'd just create the PR and work from here. As such, this closes #30 if merged.