Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Log Level to the BudgetTrackingEvent itself #113

Open
baruchiro opened this issue Oct 13, 2020 · 1 comment
Open

Add the Log Level to the BudgetTrackingEvent itself #113

baruchiro opened this issue Oct 13, 2020 · 1 comment

Comments

@baruchiro
Copy link
Collaborator

I think it would be cleaner to add the level to the BudgetTrackingEvent itself, setting it by default to INFO and having error set it to ERROR. Then you won't need this class and can use the event publisher directly.

In the current implementation you don't have access to the full api of the emitter which is useful (see comment about the option to set the status by listening to events)

Originally posted by @brafdlog in #110 (comment)

@baruchiro baruchiro mentioned this issue Oct 13, 2020
@baruchiro
Copy link
Collaborator Author

Maybe this issue is actually about/depends on moving to events payload as classes.

brafdlog pushed a commit that referenced this issue Dec 22, 2020
Footer with profile cards
@baruchiro baruchiro changed the title Add the Level to the BudgetTrackingEvent itself Add the Log Level to the BudgetTrackingEvent itself Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant