error.h: No such file or directory

[danielkucera]

What is this include for? If I comment it out, the code compiles OK:

tune.c:44:10: fatal error: error.h: No such file or directory
 #include <error.h>
          ^~~~~~~~~

[braice]

Hello Is it to get a description of the error messages Did you made some code changes, the real filename have an s, it is error*s*.h https://github.com/braice/MuMuDVB/blob/mumudvb2/src/errors.h brice Le sam. 29 déc. 2018 à 17:18, Daniel Kucera <notifications@github.com> a écrit :

…

What is this include for? If I comment it out, the code compiles OK: tune.c:44:10: fatal error: error.h: No such file or directory #include <error.h> ^~~~~~~~~ — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#236>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUUD_YjbxEpSLgCJwJueCOfMIOPKnyeks5u9-odgaJpZM4Zkuva> .

[danielkucera]

Hi, I did not make any changes, it's like this in the original code from master branch:
https://github.com/braice/MuMuDVB/blob/mumudvb2/src/tune.c#L44

I was just compiling for OpenWRT.

[braice]

Hello Ok so I think it is this one https://www.gnu.org/software/gnulib/manual/html_node/error_002eh.html https://code.woboq.org/userspace/glibc/misc/error.h.html Try to remove it and let me know if the compilation is OK Brice Le dim. 30 déc. 2018 à 16:19, Daniel Kucera <notifications@github.com> a écrit :

…

Hi, I did not make any changes, it's like this in the original code from master branch: https://github.com/braice/MuMuDVB/blob/mumudvb2/src/tune.c#L44 I was just compiling for OpenWRT. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#236 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUUDySau5i-yCxwJpFEEEVE3zXC1Mbgks5u-S3PgaJpZM4Zkuva> .

[danielkucera]

After commenting out the line, the code compiles and binary works. OpenWRT probably uses musl:
toolchain-mipsel_24kc_gcc-7.3.0_musl

[danielkucera]

It compiles without that line even with gcc version 7.3.0 (Ubuntu 7.3.0-27ubuntu1~18.04)

[danielkucera]

@braice is that include really needed?

[braice]

Indeed it is an historical left over. 2cf9521 It can be safely removed Le lun. 7 janv. 2019 à 09:11, Daniel Kucera <notifications@github.com> a écrit :

…

@braice <https://github.com/braice> is that include really needed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#236 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUUDyznzqyn78H9vP-m9sZcPq-ttwY7ks5vA1WsgaJpZM4Zkuva> .

[braice]

Removed !!! Thank you ! Le sam. 12 janv. 2019 à 16:45, Brice Dubost <braice@braice.net> a écrit :

…

Indeed it is an historical left over. 2cf9521 It can be safely removed Le lun. 7 janv. 2019 à 09:11, Daniel Kucera ***@***.***> a écrit : > @braice <https://github.com/braice> is that include really needed? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#236 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAUUDyznzqyn78H9vP-m9sZcPq-ttwY7ks5vA1WsgaJpZM4Zkuva> > . >

[danielkucera]

Thank you.
I don't know why did I make that referenced pull request against my own master... 🤦‍♂️

If you are interested, here is a working OpenWRT package definition:
https://github.com/danielkucera/openwrt-packages/tree/master/mumudvb

[braice]

Le lun. 21 janv. 2019 à 18:00, Daniel Kucera <notifications@github.com> a écrit :

If you are interested, here is a working OpenWRT package definition: https://github.com/danielkucera/openwrt-packages/tree/master/mumudvb

Yes I am, can you do a pull request ? ! Thank you