Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest changes to the Braid system start appear to cause issues for Emacs/Cider dev environment. #145

Closed
eipplusone opened this issue Jun 30, 2018 · 2 comments

Comments

@eipplusone
Copy link

eipplusone commented Jun 30, 2018

With the latest changes to the Braid system start, I can no longer reliably start it within Emacs/Cider.

Firstly, figwheel fails to compile cljs:

Failed to compile build :desktop-dev from ["src/braid" "src/retouch"] in 2.911 seconds.
----  Could not Analyze  target/classes/braid/core/modules_dummy.cljs  ----

  Could not locate braid/core/module_helpers__init.class or braid/core/module_helpers.clj on classpath. Please check that namespaces with dashes use underscores in the Clojure file name.

----  Analysis Error : Please see target/classes/braid/core/modules_dummy.cljs  ----

I'm unable to find that file or the gen-module-requires macro anywhere in the project.

Could it be that the module_helpers.cljs was forgotten on master?

Secondly, the change has an unfortunate effect of working against how Cider like to have the repls started. When I run cider-jack-in-clojurescript it starts lein repl and lein figwheel separately with piggieback and other dependencies injected that are compatible with other nrepl middleware(nrepl-refactor for example).

Cider provides cider-clojurescript-connect function, but I would need to add the right dependencies in the project itself.

Was it done to simplify the setup process in IDEs like Cursive? I understand that not everyone is using Emacs; the docs here https://github.com/braidchat/braid/blob/master/docs/dev/getting-up-and-running-in-development.md do need to be updated though(the Emacs portion).

@rafd
Copy link
Member

rafd commented Jul 2, 2018

The figwheel compile issue may be stale files. Try nuking target and the js files. 'rm -rf target' and 'rm -rf resources/public/js'

To not start figwheel via the start! function, you can create a new helper function 'start-without-figwheel' that works similarly to the one in braid.core

Not at computer right now so can't test.

@eipplusone
Copy link
Author

Well it seems like this is more of an issue pertaining to my environment than to the actual project, so i'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants