Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a cleaning instruction fo clang++ builds #55

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Conversation

rafaelcn
Copy link
Collaborator

When compiling with clang++ it generates .dwo files, the Makefile now removes it in the end of the build.

Signed-off-by: Rafael Campos Nunes rafaelnunes@engineer.com

    When compiling with clang++ it generates .dwo files, the Makefile
now removes it in the end of the build.

Signed-off-by: Rafael Campos Nunes <rafaelnunes@engineer.com>
@luizperes
Copy link
Member

Do you think that you are able to check this one here as well: #54?

@rafaelcn
Copy link
Collaborator Author

Sure, will get my hands on it :-)

@luizperes
Copy link
Member

THANKS! Should we put that on the same PR? What do you think?

@rafaelcn
Copy link
Collaborator Author

rafaelcn commented Oct 26, 2017

Well, that doesn't reflect the title of the same PR but it's okay for me. We'll need to change the title and the commit message though.

@luizperes
Copy link
Member

I dont think that I get those files xD .dwo

@rafaelcn
Copy link
Collaborator Author

Well, I figure out that we need those *.dwo files when debugging Brain compiled with clang. So I just removed those commands and told the Makefile to move those *.dwo files when building a debug version of Brain.

    It looks like we need those *.dwo files to debug Brain when built
with clang.

Signed-off-by: Rafael Campos Nunes <rafaelnunes@engineer.com>
@rafaelcn
Copy link
Collaborator Author

Things are more than meets the eye. Those are files are DWARF files, used to make the final Brain executable, they are dwarf objects, hence the .dwo extension. I think #54 is somehow related to the linking process of Brain and with what you said inside that issue. Here's a related issue, quite close to what we are experiencing.

@rafaelcn rafaelcn self-assigned this Oct 27, 2017
Signed-off-by: Rafael Campos Nunes <rafaelnunes@engineer.com>
@luizperes
Copy link
Member

Interesting, any news on #54?

@rafaelcn rafaelcn mentioned this pull request Oct 27, 2017
@luizperes
Copy link
Member

It's been approved already xD

@rafaelcn rafaelcn merged commit 1cae31c into brain-labs:dev Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants