Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for application emojis #1207

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Jul 21, 2024

This PR adds support for application emojis.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 8de4471
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/669e2ced75535300083f5b70
😎 Deploy Preview https://deploy-preview-1207--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jul 21, 2024
src/dpp/cluster/emoji.cpp Outdated Show resolved Hide resolved
src/dpp/cluster/emoji.cpp Outdated Show resolved Hide resolved
@Jaskowicz1
Copy link
Contributor Author

PR is fully tested now and is ready 🫡

@ruslan-ilesik
Copy link
Contributor

Would you mind if I ask about adding sync versions of it? (Also coro would be nice, but I think this is not mandatory)

@Jaskowicz1
Copy link
Contributor Author

Would you mind if I ask about adding sync versions of it? (Also coro would be nice, but I think this is not mandatory)

oh yeah forgor to let them auto gen

@Jaskowicz1 Jaskowicz1 merged commit ced36fd into dev Jul 22, 2024
90 checks passed
@Jaskowicz1 Jaskowicz1 deleted the application_emojis branch July 23, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants