Error popups and default X range when no timestamps

[adrien-berchet]

No description provided.

[anilbey]

good idea, we can delete them

[anilbey]

Great, with this change the BBP NWBs are supported!
The two-way slider and the separation of the theme section are also very nice.

One question: didn't following the reference to another dataset work?

[anilbey]

One more feedback: when we resize the popup to be veeery big. Then we cannot resize it back to the small size because the resize icon moves out of the program. Maybe making it non-resizable will be better.

[anilbey]

One question: didn't following the reference to another dataset work?

I just noticed said something wrong yesterday. Below is the link that Rajnish uses and it works fine. 👍

 link       /data_organization/Cell 1/Step/repetition 1/sweep 13/ics__Step__13 -> /stimulus/presentation/ics__Step__13

[adrien-berchet]

Good catch for the size of the popup, I made it non-resizable :)
I did not try to follow the references yet, I guess we can do it in another PR.

[anilbey]

I did not try to follow the references yet, I guess we can do it in another PR.

Actually following the references work already. When I use h5dump -n "filename" to display the contents, it shows the links and the NWBView displays what those links are pointing at.

 dataset    /acquisition/ic__Step__1/data
 link       /acquisition/ic__Step__1/electrode -> /general/intracellular_ephys/Electrode 1

The dataset we could not display is of this type (H5T_COMPOUND). I don't know why the type descriptor does not work for this type.

❯ h5dump -d /general/intracellular_ephys/intracellular_recordings/stimuli/stimulus 99111002.nwb      ─╯
HDF5 "99111002.nwb" {
DATASET "/general/intracellular_ephys/intracellular_recordings/stimuli/stimulus" {
   DATATYPE  H5T_COMPOUND {
      H5T_STD_I32LE "idx_start";
      H5T_STD_I32LE "count";
      H5T_REFERENCE { H5T_STD_REF_OBJECT } "timeseries";
   }

[adrien-berchet]

Ah yeah ok, each element of this dataset is a tuple of 3 elements (2 ints and one ref).

[adrien-berchet]

One more weird thing: when I move a plot window of a group that is referenced by another one, there is a weird message appearing in red at the bottom left of the window:

Double use of widget ID 58D6

(or other ID, depending on the window)
I don't know why yet, but it seems it still works properly even with this warning.

EDIT: It happens only when the 2 groups are expanded in the tree.

[anilbey]

The entity manager of the GUI library stores the Windows using their title names as IDs.
https://github.com/emilk/egui/blob/master/crates/egui/src/containers/window.rs#L38-L40

[adrien-berchet]

Hmmm yeah ok, And we set the dataset names as titles, which is probably the same because of the reference. We should probably use the actual dataset path instead of the name to fix this.

[anilbey]

The whole path can be very long to be displayed on the title though. Maybe the actual dataset path can go to this window.id(...).

/// If you need a changing title, you must call window.id(…) with a fixed id.
https://github.com/emilk/egui/blob/master/crates/egui/src/containers/window.rs#L40

[adrien-berchet]

Ah maybe indeed