Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type into buttonType for buttons #1358

Merged
merged 3 commits into from Dec 18, 2017
Merged

Change type into buttonType for buttons #1358

merged 3 commits into from Dec 18, 2017

Conversation

burakukula
Copy link
Contributor

Fixes #1355

@matikrk
Copy link
Contributor

matikrk commented Dec 18, 2017

BUTTON_TYPE from ButtonPrimary it's different from ButtonSecondary
So it's should name same.

There is 2 ways:

  • name it BUTTON_PRIMARY_TYPE & BUTTON_SECONDARY_TYPE
  • or make it consistent - same types in both - IMHO better

WDYT @aju @kdzwinel @matzimowski ?

@burakukula
Copy link
Contributor Author

@matikrk like that? 🙃

@burakukula burakukula merged commit a9490d1 into master Dec 18, 2017
@burakukula burakukula deleted the btn-type-fix branch December 18, 2017 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aju aju aju approved these changes

@anna-wro anna-wro anna-wro approved these changes

@matikrk matikrk matikrk approved these changes

@kdzwinel kdzwinel Awaiting requested review from kdzwinel

@matzimowski matzimowski Awaiting requested review from matzimowski

@tomasz-sodzawiczny tomasz-sodzawiczny Awaiting requested review from tomasz-sodzawiczny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@burakukula @matikrk @aju @anna-wro