New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical rhythm #295
Vertical rhythm #295
Conversation
@@ -3,24 +3,39 @@ $include-html: false !default; | |||
@if ($include-html) { | |||
|
|||
.mint-content-box { | |||
|
|||
&__title { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This container is supposed to have only headers. Some of them can wrap, like mint-header--secondary
, hence the min-height.
👍 |
@@ -0,0 +1,40 @@ | |||
.mint-link { | |||
@include remove-descenders; | |||
cursor: pointer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdzwinel should this pointer go as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about that one - links natively have cursor: pointer
, so this setting only makes sense if we create something that should look and feel like link but should not be an <a>
. Do we have such cases?
Anyway, this works on opera mini (tested in footer where we have links now), so that aspect is not an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, clear. I'll leave it as is 👍
Besides the small things mentioned - 👍 |
well done! this is huge improvement ;) |
Lets 🐑 🇮🇹 |
Made it possible to check rhythm scaling
1d772f5
to
8541b54
Compare
Note: this PR will be merged into
master
and will be a huge breaking change!Close #13
Close #101
Close #230
Close #192
Close #112
Relates to #103, #104, #108.
Mockup used: http://typecast.com/QhQQkkddGr/share/87eeaf5d967424f871d1236edad36ee3d46a85b6KrPQgjrbw
Incorporate changes from: #254 #271 #291
Changes
This PR introduces changes to the whole code base and touches almost every non-trivial component.
Font Map and
fontSize
functionFrom now on there is a font map, which incorporates all possible font sizes which should be used across components.
There are 2 axes:
default, tiny, small, medium, large, xlarge, xxlarge
default, obscure, standout, headline, header
Ideally, this map should not change.
Additionally, there is a function for getting font size based on size name,
fontSize
:rhythm
functionThere is a function for easier adding sizes, which are multiples of
$baseline
:The usage is the same as in ruby's
compass
.typeVariant
mixinUsed to set up copy text properties.
Allows text to be pushed to baseline.
See details: #254
components-container
mixinUsed in containers to mark holes, where other arbitrary components can go.
Uses flexbox + wrap + vertical centering by default.
Pending Refactors
mint-checkbox
implementation need to be reconsidered Revisit checkbox implementation #299mint-list
should be transformed to container using flexbox Generic "holes" for containers with unlimited number of components in a single row #104mint-promo-box
should be revisited Revisit promo-box #300inline-component
/small-component
Introduceinline-component
/small-component
#301inline-block
elements problems (descenders, repositioned baseline, baseline vs overflow:hidden)$fontWeightBlack
variable usage - usebolder
instead omit$fontWeightBlack
variable usage #304Breaking Changes
Containers:
mint-bubble
, added__hole
mint-box
, added__hole
mint-content-box
, added__title
footer
lost all original styling for holes. Usemint-link
andmint-text
instead!Components:
.mint-breadcrumb-list
lost its specific text styles. Now it is more like a container - you can put arbitrary text blocks inside.Text:
These things have changed it dimensions and MAY need refactoring: