-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pca fix progress bar #626
pca fix progress bar #626
Conversation
This is interesting. I am wondering if instead of 'nesting' progress bar, if we should not instead allow to have multiple progress bars (#614) Maybe something like this (https://www.mathworks.com/matlabcentral/fileexchange/26589-multiwaitbar): |
Thanks @rcassani, I'll make that a new bst_progress command: pBar = bst_progress('reset', pBar) Hi @Edouard2laire, indeed I saw your post at the time and like it, but I doubt we'll have resources for such improvements soon, with François being away. This PR is just a quick fix to follow Bst "nesting conventions" - my recent changes had made some processes stick at 100% (e.g. connectivity with PCA scouts). |
Thanks @Edouard2laire, indeed that PR is in the queue of things to do.
I think we can add two methods 'GetBar' and 'SetBar'.
|
@Moo-Marc, last two commits should do the trick. Can you test that it behaves as expected? |
@rcassani Few additional tweaks. Works ok now! |
Improved progress bar "nesting" for recent modifications (PCA, flattening, scouts)