Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pca fix progress bar #626

Merged
merged 5 commits into from
Jun 14, 2023
Merged

pca fix progress bar #626

merged 5 commits into from
Jun 14, 2023

Conversation

Moo-Marc
Copy link
Collaborator

Improved progress bar "nesting" for recent modifications (PCA, flattening, scouts)

toolbox/math/bst_pca.m Outdated Show resolved Hide resolved
@Edouard2laire
Copy link
Contributor

This is interesting. I am wondering if instead of 'nesting' progress bar, if we should not instead allow to have multiple progress bars (#614)

Maybe something like this (https://www.mathworks.com/matlabcentral/fileexchange/26589-multiwaitbar):
1596470707-2

@Moo-Marc
Copy link
Collaborator Author

Thanks @rcassani, I'll make that a new bst_progress command: pBar = bst_progress('reset', pBar)
Would you have another suggestion instead of calling it 'reset'? Maybe 'restart', or even overload 'start'?

Hi @Edouard2laire, indeed I saw your post at the time and like it, but I doubt we'll have resources for such improvements soon, with François being away. This PR is just a quick fix to follow Bst "nesting conventions" - my recent changes had made some processes stick at 100% (e.g. connectivity with PCA scouts).

@rcassani
Copy link
Member

Thanks @Edouard2laire, indeed that PR is in the queue of things to do.

Would you have another suggestion instead of calling it 'reset'? Maybe 'restart', or even overload 'start'?

I think we can add two methods 'GetBar' and 'SetBar'.
Will do

oldBar = bst_progress('GetBar');
bst_progress('SetBar', oldBar);

@rcassani
Copy link
Member

@Moo-Marc, last two commits should do the trick. Can you test that it behaves as expected?

@Moo-Marc
Copy link
Collaborator Author

@rcassani Few additional tweaks. Works ok now!

@rcassani rcassani merged commit f9b29ea into brainstorm-tools:master Jun 14, 2023
rcassani added a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants