Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when completing the purchase and main activity is destroyed #26

Merged
merged 1 commit into from
May 13, 2015
Merged

Fix crash when completing the purchase and main activity is destroyed #26

merged 1 commit into from
May 13, 2015

Conversation

alexeystep
Copy link
Contributor

Initial conditions:

  • Turn on "Do not keep activities" flag in Developer Options

Scenario:

  • Press Drop-In button
  • Enter credit card information e.g. 4242 4242 4242 4242
  • Press Buy button

Expected:

  • Main Activity is in the foreground displaying the nonce
    Actual:
  • Demo app crashes

@alexeystep
Fix crash when completing the purchase and main activity is destroyed
7bc7a4f 
Initial conditions:
- Turn on "Do not keep activities" flag in Developer Options

Scenario:
 - Press Drop-In button
 - Enter credit card information e.g. 4242 4242 4242 4242
 - Press Buy button

Expected:
 - Main Activity is in the foreground displaying the nonce
Actual:
 - Demo app crashes
@alexeystep alexeystep mentioned this pull request Apr 13, 2015
Closed
lkorth added a commit that referenced this pull request May 13, 2015
@lkorth
Merge pull request #26 from alexeystep/FixCrashInDemoWhenDoNotKeepAct…
a9b819e 
…ivitiesIsOn

Fix crash when completing the purchase and main activity is destroyed
@lkorth lkorth merged commit a9b819e into braintree:master May 13, 2015
@lkorth
Copy link
Member

lkorth commented May 13, 2015

Thanks for the contribution @alexeystep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeystep @lkorth