Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Google Play Services version to 8.1.0 or above #50

Conversation

nvanbenschoten
Copy link

In reference to https://code.google.com/p/android/issues/detail?id=187483, clients depending on both Google Play Services 8.1.0 and on libraries who depend on Google Play Services < 8.1.0 will fail building, giving the dex error:

Unknown source file : Uncaught translation error: com.android.dx.cf.code.SimException: com.android.dx.rop.cst.CstMethodRef cannot be cast to com.android.dx.rop.cst.CstInterfaceMethodRef
Unknown source file : Uncaught translation error: com.android.dx.cf.code.SimException: com.android.dx.rop.cst.CstMethodRef cannot be cast to com.android.dx.rop.cst.CstInterfaceMethodRef
Unknown source file : 2 errors; aborting

This pull request is bumping up the gms wallet version in the Android Braintree SDK from 7.8.0 to 8.1.0. At first glance, it looks like this update is completely stable, and there don't seem to be any breaking changes.

@nvanbenschoten
Copy link
Author

Based on the Play Services Release History, it doesn't look like the wallet API was touched between these two versions.

@lkorth
Copy link
Member

lkorth commented Oct 5, 2015

@nvanbenschoten: Thanks for the PR! We have an update going out today to that already includes this change.

One thing worth noting, since the dependency on Google Play Services Wallet is optional in braintree_android, using this library in an app that uses 8.1.0 does not generate a compile error, but method calls to the wallet API appear to fail.

@lkorth lkorth closed this Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants