Include all files under spec/ in gemspec. #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Let us do some testing on our end before we make the change. Cheers, Cory |
|
Hey Gabe, Thanks for the input! We'll be including this in our next release. Lionel and Brian |
crookedneighbor
pushed a commit
that referenced
this pull request
Dec 26, 2017
…xample_with_nonce supdev AMb0Nvv0 - update readme example with nonce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that e.g.
spec/ssl/privateKey.keyisn't included with the current pattern ofs.filesin the gemspec.My use case is for fake_braintree - I'd like to run the Braintree integration specs against the fake_braintree server (!!), but without the
privateKey.key, there are a bunch ofECONNREFUSEDerrors.Let me know if the use case is confusing.