Check if Activity is Finishing Before Browser Switch #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwylder
approved these changes
Dec 19, 2022
| @@ -216,7 +220,7 @@ public void captureResult(@NonNull FragmentActivity activity) { | |||
| Uri deepLinkUrl = intent.getData(); | |||
| if (deepLinkUrl != null) { | |||
| BrowserSwitchResult result = | |||
| new BrowserSwitchResult(BrowserSwitchStatus.SUCCESS, request, deepLinkUrl); | |||
| new BrowserSwitchResult(BrowserSwitchStatus.SUCCESS, request, deepLinkUrl); | |||
There was a problem hiding this comment.
Is this the indentation level we want?
There was a problem hiding this comment.
Yeah it's the one enforced by the linter. It defaults to a double indent for continuation lines. We don't have a hard convention in place yet though might be worth changing.
sshropshire
force-pushed
the
check_if_activity_is_finishing_before_browser_switch
branch
from
98e3337
to
0e410fb
Compare
sshropshire
deleted the
check_if_activity_is_finishing_before_browser_switch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors