This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Use json-schema gem instead of json_schema #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll try to take a look at this later this week. |
|
Gentle ping~ 😄 |
open_api_parser.gemspec
Outdated
| @@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
| spec.required_ruby_version = "~> 2.0" | |||
|
|
|||
| spec.add_dependency "addressable", "~> 2.3" | |||
| spec.add_dependency "json_schema", "~> 0.15.0" | |||
| spec.add_dependency "json-schema", "~> 2.8.0" | |||
There was a problem hiding this comment.
isn't that dependency a bit too restrictive? IMHO ~> 2.8 is better.
|
@drewolson do you have a rough idea on when you'll have time to have a look? We can always use our fork in the meantime but that's obviously not an ideal solution. |
|
I plan on investigating this Friday. |
drewolson
approved these changes
Nov 10, 2017
|
Much appreciated @drewolson! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #7 and in response to the
json_schemagem not properly validating nested objects, this PR switches the json_schema gem with the json-schema gem.We found this issue when there was an OpenAPI spec file with an invalid HTTP method type.
Despite the spec defining the allowed values in /resources/swagger_meta_schema.json#L306-L343, those rules were not being enforced by the
json_schemagem and the invalid spec was considered valid. Using thejson-schemagem, validation was performed properly:Also, fixed some of the descriptions in
valid_spec.yamlthat were copy pasted.@drewolson @jfeltesse-mdsol @jcarres-mdsol @ykitamura-mdsol