Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a software-only libGL in the casa-run-5.3 image #322

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

ylep
Copy link
Member

@ylep ylep commented Jan 9, 2023

We used to ship a software-only libGL in casa-run-5.0 but it was dropped during the upgrade to newer Ubuntu versions. Here it is back for the casa-run-5.3 image, but this time it is compiled during the creation of the image instead of being shipped pre-compiled (it is actually quite fast to compile).

This is part of an attempt to fix #321 but a software-only libGL could be useful in other scenarios.

I have built the new images and am ready to push them if you approve this PR :-)

@ylep ylep requested a review from denisri January 9, 2023 15:43
@ylep ylep changed the base branch from master to brainvisa-5.1 January 9, 2023 15:44
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (brainvisa-5.1@da76b01). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             brainvisa-5.1     #322   +/-   ##
================================================
  Coverage                 ?   16.34%           
================================================
  Files                    ?       21           
  Lines                    ?     4031           
  Branches                 ?        0           
================================================
  Hits                     ?      659           
  Misses                   ?     3372           
  Partials                 ?        0           

@ylep ylep marked this pull request as draft January 9, 2023 15:59
@ylep
Copy link
Member Author

ylep commented Jan 9, 2023

If you don't mind, I would prefer to wait until we better understand #321 before actually adding the software-only libGL: we still don't know if it is really required, or maybe the system-provided mesa can work with the LIBGL_ALWAYS_SOFTWARE environment variable? (see https://docs.mesa3d.org/envvars.html#envvar-LIBGL_ALWAYS_SOFTWARE)

@denisri
Copy link
Contributor

denisri commented Jan 9, 2023

So I let you test further using the LIBGL_ALWAYS_SOFTWARE env variable ?

@ylep ylep marked this pull request as ready for review January 16, 2023 11:06
@ylep
Copy link
Member Author

ylep commented Jan 16, 2023

LIBGL_ALWAYS_SOFTWARE does not ameliorate any of the issues described in #321.

As a result, I propose to include the software-only libGL in the image even though it does not help with older X2Go (4.0.0), because it still allows to fix glxinfo and glxgears (again, see #321).

@ylep ylep merged commit 992e458 into brainvisa-5.1 Jan 16, 2023
@ylep ylep deleted the software_libGL branch January 16, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt applications crash under X2Go in the casa-run-5.3 image
2 participants