Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Attachment codec types #305

Closed
Euklios opened this issue Mar 5, 2024 · 0 comments · Fixed by #306
Closed

Add missing Attachment codec types #305

Euklios opened this issue Mar 5, 2024 · 0 comments · Fixed by #306

Comments

@Euklios
Copy link
Collaborator

Euklios commented Mar 5, 2024

Is your feature request related to a problem? Please describe.
FFmpeg codecs can handle video, audio, subtilte, and data streams, as implemented by this wrapper.
However, additionally attachment codecs are supported.

Describe the solution you'd like
Add ATTACHMENT to Codec enum.

Describe alternatives you've considered
The only solution I'm aware of is to ignore it.
Default builds of ffmpeg don't include any attachment codecs.
However, as it is supported, we should implement it as well.
Additionally, this makes the Codec.Type enum equal to the CodecType enum, which means we could merge them.
This also makes sense in a logical way, a stream has been encoded with CodecType, therefore encoding using a Codec with the same type would be reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant