Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dynamic sub profile selection #1162

Merged
merged 7 commits into from
Oct 21, 2022
Merged

Implement dynamic sub profile selection #1162

merged 7 commits into from
Oct 21, 2022

Conversation

bramstroker
Copy link
Owner

@bramstroker bramstroker commented Oct 16, 2022 •
edited
Loading

Todo:

  • Error handling when sub profile does not exist
  • Cleanup matcher creation logic, and add some validation there
  • More tests. also for default (add to test_power_profile.py)
  • Remove requires_manual_configuration from model.json
  • Modify the model.json for models which can use this new feature

@bramstroker bramstroker mentioned this pull request Oct 16, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3299176595

  • 50 of 52 (96.15%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 96.604%
Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/powercalc/power_profile/power_profile.py 43 45 95.56%
Totals Coverage Status
Change from base Build 3299164232: -0.03%
Covered Lines: 2503
Relevant Lines: 2591
💛 - Coveralls

@bramstroker bramstroker merged commit e567a33 into master Oct 21, 2022
@bramstroker bramstroker deleted the feat/sub-profile-select branch October 22, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bramstroker @coveralls